invrequest.cpp

Go to the documentation of this file.

// Copyright (c) 2020 The Bitcoin Core developers
// Distributed under the MIT software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
#include <invrequest.h>
 
#include <crypto/siphash.h>
#include <net.h>
#include <random.h>
 
#include <boost/multi_index/ordered_index.hpp>
#include <boost/multi_index_container.hpp>
 
#include <cassert>
#include <chrono>
#include <functional>
#include <unordered_map>
#include <utility>
 
namespace {
 
enum class State : uint8_t {
    CANDIDATE_DELAYED,
    CANDIDATE_READY,
    CANDIDATE_BEST,
    REQUESTED,
    COMPLETED,
};
 
using SequenceNumber = uint64_t;
 
struct Announcement {
    const uint256 m_invid;
    std::chrono::microseconds m_time;
    const NodeId m_peer;
    const SequenceNumber m_sequence : 60;
    const bool m_preferred : 1;
 
    uint8_t m_state : 3;
 
    State GetState() const { return static_cast<State>(m_state); }
 
    void SetState(State state) { m_state = static_cast<uint8_t>(state); }
 
    bool IsSelected() const {
        return GetState() == State::CANDIDATE_BEST ||
               GetState() == State::REQUESTED;
    }
 
    bool IsWaiting() const {
        return GetState() == State::REQUESTED ||
               GetState() == State::CANDIDATE_DELAYED;
    }
 
    bool IsSelectable() const {
        return GetState() == State::CANDIDATE_READY ||
               GetState() == State::CANDIDATE_BEST;
    }
 
    Announcement(const uint256 &invid, NodeId peer, bool preferred,
                 std::chrono::microseconds reqtime, SequenceNumber sequence)
        : m_invid(invid), m_time(reqtime), m_peer(peer), m_sequence(sequence),
          m_preferred(preferred),
          m_state(static_cast<uint8_t>(State::CANDIDATE_DELAYED)) {}
};
 
using Priority = uint64_t;
 
class PriorityComputer {
    const uint64_t m_k0, m_k1;
 
public:
    explicit PriorityComputer(bool deterministic)
        : m_k0{deterministic ? 0 : GetRand(0xFFFFFFFFFFFFFFFF)},
          m_k1{deterministic ? 0 : GetRand(0xFFFFFFFFFFFFFFFF)} {}
 
    Priority operator()(const uint256 &invid, NodeId peer,
                        bool preferred) const {
        uint64_t low_bits = CSipHasher(m_k0, m_k1)
                                .Write(invid.begin(), invid.size())
                                .Write(peer)
                                .Finalize() >>
                            1;
        return low_bits | uint64_t{preferred} << 63;
    }
 
    Priority operator()(const Announcement &ann) const {
        return operator()(ann.m_invid, ann.m_peer, ann.m_preferred);
    }
};
 
// Definitions for the 3 indexes used in the main data structure.
//
// Each index has a By* type to identify it, a By*View data type to represent
// the view of announcement it is sorted by, and an By*ViewExtractor type to
// convert an announcement into the By*View type. See
// https://www.boost.org/doc/libs/1_58_0/libs/multi_index/doc/reference/key_extraction.html#key_extractors
// for more information about the key extraction concept.
 
// The ByPeer index is sorted by (peer, state == CANDIDATE_BEST, invid)
//
// Uses:
// * Looking up existing announcements by peer/invid, by checking both (peer,
//   false, invid) and (peer, true, invid).
// * Finding all CANDIDATE_BEST announcements for a given peer in
//   GetRequestable.
struct ByPeer {};
using ByPeerView = std::tuple<NodeId, bool, const uint256 &>;
struct ByPeerViewExtractor {
    using result_type = ByPeerView;
    result_type operator()(const Announcement &ann) const {
        return ByPeerView{ann.m_peer, ann.GetState() == State::CANDIDATE_BEST,
                          ann.m_invid};
    }
};
 
// The ByInvId index is sorted by (invid, state, priority).
//
// Note: priority == 0 whenever state != CANDIDATE_READY.
//
// Uses:
// * Deleting all announcements with a given invid in ForgetInvId.
// * Finding the best CANDIDATE_READY to convert to CANDIDATE_BEST, when no
//   other CANDIDATE_READY or REQUESTED announcement exists for that invid.
// * Determining when no more non-COMPLETED announcements for a given invid
//   exist, so the COMPLETED ones can be deleted.
struct ByInvId {};
using ByInvIdView = std::tuple<const uint256 &, State, Priority>;
class ByInvIdViewExtractor {
    const PriorityComputer &m_computer;
 
public:
    explicit ByInvIdViewExtractor(const PriorityComputer &computer)
        : m_computer(computer) {}
    using result_type = ByInvIdView;
    result_type operator()(const Announcement &ann) const {
        const Priority prio =
            (ann.GetState() == State::CANDIDATE_READY) ? m_computer(ann) : 0;
        return ByInvIdView{ann.m_invid, ann.GetState(), prio};
    }
};
 
enum class WaitState {
    FUTURE_EVENT,
    NO_EVENT,
    PAST_EVENT,
};
 
WaitState GetWaitState(const Announcement &ann) {
    if (ann.IsWaiting()) {
        return WaitState::FUTURE_EVENT;
    }
    if (ann.IsSelectable()) {
        return WaitState::PAST_EVENT;
    }
    return WaitState::NO_EVENT;
}
 
// The ByTime index is sorted by (wait_state, time).
//
// All announcements with a timestamp in the future can be found by iterating
// the index forward from the beginning. All announcements with a timestamp in
// the past can be found by iterating the index backwards from the end.
//
// Uses:
// * Finding CANDIDATE_DELAYED announcements whose reqtime has passed, and
//   REQUESTED announcements whose expiry has passed.
// * Finding CANDIDATE_READY/BEST announcements whose reqtime is in the future
//   (when the clock time went backwards).
struct ByTime {};
using ByTimeView = std::pair<WaitState, std::chrono::microseconds>;
struct ByTimeViewExtractor {
    using result_type = ByTimeView;
    result_type operator()(const Announcement &ann) const {
        return ByTimeView{GetWaitState(ann), ann.m_time};
    }
};
 
using Index = boost::multi_index_container<
    Announcement,
    boost::multi_index::indexed_by<
        boost::multi_index::ordered_unique<boost::multi_index::tag<ByPeer>,
                                           ByPeerViewExtractor>,
        boost::multi_index::ordered_non_unique<boost::multi_index::tag<ByInvId>,
                                               ByInvIdViewExtractor>,
        boost::multi_index::ordered_non_unique<boost::multi_index::tag<ByTime>,
                                               ByTimeViewExtractor>>>;
 
template <typename Tag> using Iter = typename Index::index<Tag>::type::iterator;
 
struct PeerInfo {
    size_t m_total = 0;
    size_t m_completed = 0;
    size_t m_requested = 0;
};
 
struct InvIdInfo {
    size_t m_candidate_delayed = 0;
    size_t m_candidate_ready = 0;
    size_t m_candidate_best = 0;
    size_t m_requested = 0;
    Priority m_priority_candidate_best = std::numeric_limits<Priority>::max();
    Priority m_priority_best_candidate_ready =
        std::numeric_limits<Priority>::min();
    std::vector<NodeId> m_peers;
};
 
bool operator==(const PeerInfo &a, const PeerInfo &b) {
    return std::tie(a.m_total, a.m_completed, a.m_requested) ==
           std::tie(b.m_total, b.m_completed, b.m_requested);
};
 
std::unordered_map<NodeId, PeerInfo> RecomputePeerInfo(const Index &index) {
    std::unordered_map<NodeId, PeerInfo> ret;
    for (const Announcement &ann : index) {
        PeerInfo &info = ret[ann.m_peer];
        ++info.m_total;
        info.m_requested += (ann.GetState() == State::REQUESTED);
        info.m_completed += (ann.GetState() == State::COMPLETED);
    }
    return ret;
}
 
std::map<uint256, InvIdInfo>
ComputeInvIdInfo(const Index &index, const PriorityComputer &computer) {
    std::map<uint256, InvIdInfo> ret;
    for (const Announcement &ann : index) {
        InvIdInfo &info = ret[ann.m_invid];
        // Classify how many announcements of each state we have for this invid.
        info.m_candidate_delayed +=
            (ann.GetState() == State::CANDIDATE_DELAYED);
        info.m_candidate_ready += (ann.GetState() == State::CANDIDATE_READY);
        info.m_candidate_best += (ann.GetState() == State::CANDIDATE_BEST);
        info.m_requested += (ann.GetState() == State::REQUESTED);
        // And track the priority of the best CANDIDATE_READY/CANDIDATE_BEST
        // announcements.
        if (ann.GetState() == State::CANDIDATE_BEST) {
            info.m_priority_candidate_best = computer(ann);
        }
        if (ann.GetState() == State::CANDIDATE_READY) {
            info.m_priority_best_candidate_ready =
                std::max(info.m_priority_best_candidate_ready, computer(ann));
        }
        // Also keep track of which peers this invid has an announcement for
        // (so we can detect duplicates).
        info.m_peers.push_back(ann.m_peer);
    }
    return ret;
}
 
} // namespace
 
class InvRequestTrackerImpl : public InvRequestTrackerImplInterface {
    SequenceNumber m_current_sequence{0};
 
    const PriorityComputer m_computer;
 
    Index m_index;
 
    std::unordered_map<NodeId, PeerInfo> m_peerinfo;
 
public:
    void SanityCheck() const {
        // Recompute m_peerdata from m_index. This verifies the data in it as it
        // should just be caching statistics on m_index. It also verifies the
        // invariant that no PeerInfo announcements with m_total==0 exist.
        assert(m_peerinfo == RecomputePeerInfo(m_index));
 
        // Calculate per-invid statistics from m_index, and validate
        // invariants.
        for (auto &item : ComputeInvIdInfo(m_index, m_computer)) {
            InvIdInfo &info = item.second;
 
            // Cannot have only COMPLETED peer (invid should have been forgotten
            // already)
            assert(info.m_candidate_delayed + info.m_candidate_ready +
                       info.m_candidate_best + info.m_requested >
                   0);
 
            // Can have at most 1 CANDIDATE_BEST/REQUESTED peer
            assert(info.m_candidate_best + info.m_requested <= 1);
 
            // If there are any CANDIDATE_READY announcements, there must be
            // exactly one CANDIDATE_BEST or REQUESTED announcement.
            if (info.m_candidate_ready > 0) {
                assert(info.m_candidate_best + info.m_requested == 1);
            }
 
            // If there is both a CANDIDATE_READY and a CANDIDATE_BEST
            // announcement, the CANDIDATE_BEST one must be at least as good
            // (equal or higher priority) as the best CANDIDATE_READY.
            if (info.m_candidate_ready && info.m_candidate_best) {
                assert(info.m_priority_candidate_best >=
                       info.m_priority_best_candidate_ready);
            }
 
            // No invid can have been announced by the same peer twice.
            std::sort(info.m_peers.begin(), info.m_peers.end());
            assert(
                std::adjacent_find(info.m_peers.begin(), info.m_peers.end()) ==
                info.m_peers.end());
        }
    }
 
    void PostGetRequestableSanityCheck(std::chrono::microseconds now) const {
        for (const Announcement &ann : m_index) {
            if (ann.IsWaiting()) {
                // REQUESTED and CANDIDATE_DELAYED must have a time in the
                // future (they should have been converted to
                // COMPLETED/CANDIDATE_READY respectively).
                assert(ann.m_time > now);
            } else if (ann.IsSelectable()) {
                // CANDIDATE_READY and CANDIDATE_BEST cannot have a time in the
                // future (they should have remained CANDIDATE_DELAYED, or
                // should have been converted back to it if time went
                // backwards).
                assert(ann.m_time <= now);
            }
        }
    }
 
private:
    template <typename Tag> Iter<Tag> Erase(Iter<Tag> it) {
        auto peerit = m_peerinfo.find(it->m_peer);
        peerit->second.m_completed -= it->GetState() == State::COMPLETED;
        peerit->second.m_requested -= it->GetState() == State::REQUESTED;
        if (--peerit->second.m_total == 0) {
            m_peerinfo.erase(peerit);
        }
        return m_index.get<Tag>().erase(it);
    }
 
    template <typename Tag, typename Modifier>
    void Modify(Iter<Tag> it, Modifier modifier) {
        auto peerit = m_peerinfo.find(it->m_peer);
        peerit->second.m_completed -= it->GetState() == State::COMPLETED;
        peerit->second.m_requested -= it->GetState() == State::REQUESTED;
        m_index.get<Tag>().modify(it, std::move(modifier));
        peerit->second.m_completed += it->GetState() == State::COMPLETED;
        peerit->second.m_requested += it->GetState() == State::REQUESTED;
    }
 
    void PromoteCandidateReady(Iter<ByInvId> it) {
        assert(it != m_index.get<ByInvId>().end());
        assert(it->GetState() == State::CANDIDATE_DELAYED);
        // Convert CANDIDATE_DELAYED to CANDIDATE_READY first.
        Modify<ByInvId>(it, [](Announcement &ann) {
            ann.SetState(State::CANDIDATE_READY);
        });
        // The following code relies on the fact that the ByInvId is sorted by
        // invid, and then by state (first _DELAYED, then _READY, then
        // _BEST/REQUESTED). Within the _READY announcements, the best one
        // (highest priority) comes last. Thus, if an existing _BEST exists for
        // the same invid that this announcement may be preferred over, it must
        // immediately follow the newly created _READY.
        auto it_next = std::next(it);
        if (it_next == m_index.get<ByInvId>().end() ||
            it_next->m_invid != it->m_invid ||
            it_next->GetState() == State::COMPLETED) {
            // This is the new best CANDIDATE_READY, and there is no
            // IsSelected() announcement for this invid already.
            Modify<ByInvId>(it, [](Announcement &ann) {
                ann.SetState(State::CANDIDATE_BEST);
            });
        } else if (it_next->GetState() == State::CANDIDATE_BEST) {
            Priority priority_old = m_computer(*it_next);
            Priority priority_new = m_computer(*it);
            if (priority_new > priority_old) {
                // There is a CANDIDATE_BEST announcement already, but this one
                // is better.
                Modify<ByInvId>(it_next, [](Announcement &ann) {
                    ann.SetState(State::CANDIDATE_READY);
                });
                Modify<ByInvId>(it, [](Announcement &ann) {
                    ann.SetState(State::CANDIDATE_BEST);
                });
            }
        }
    }
 
    void ChangeAndReselect(Iter<ByInvId> it, State new_state) {
        assert(new_state == State::COMPLETED ||
               new_state == State::CANDIDATE_DELAYED);
        assert(it != m_index.get<ByInvId>().end());
        if (it->IsSelected() && it != m_index.get<ByInvId>().begin()) {
            auto it_prev = std::prev(it);
            // The next best CANDIDATE_READY, if any, immediately precedes the
            // REQUESTED or CANDIDATE_BEST announcement in the ByInvId index.
            if (it_prev->m_invid == it->m_invid &&
                it_prev->GetState() == State::CANDIDATE_READY) {
                // If one such CANDIDATE_READY exists (for this invid), convert
                // it to CANDIDATE_BEST.
                Modify<ByInvId>(it_prev, [](Announcement &ann) {
                    ann.SetState(State::CANDIDATE_BEST);
                });
            }
        }
        Modify<ByInvId>(
            it, [new_state](Announcement &ann) { ann.SetState(new_state); });
    }
 
    bool IsOnlyNonCompleted(Iter<ByInvId> it) {
        assert(it != m_index.get<ByInvId>().end());
        // Not allowed to call this on COMPLETED announcements.
        assert(it->GetState() != State::COMPLETED);
 
        // This announcement has a predecessor that belongs to the same invid.
        // Due to ordering, and the fact that 'it' is not COMPLETED, its
        // predecessor cannot be COMPLETED here.
        if (it != m_index.get<ByInvId>().begin() &&
            std::prev(it)->m_invid == it->m_invid) {
            return false;
        }
 
        // This announcement has a successor that belongs to the same invid,
        // and is not COMPLETED.
        if (std::next(it) != m_index.get<ByInvId>().end() &&
            std::next(it)->m_invid == it->m_invid &&
            std::next(it)->GetState() != State::COMPLETED) {
            return false;
        }
 
        return true;
    }
 
    bool MakeCompleted(Iter<ByInvId> it) {
        assert(it != m_index.get<ByInvId>().end());
 
        // Nothing to be done if it's already COMPLETED.
        if (it->GetState() == State::COMPLETED) {
            return true;
        }
 
        if (IsOnlyNonCompleted(it)) {
            // This is the last non-COMPLETED announcement for this invid.
            // Delete all.
            uint256 invid = it->m_invid;
            do {
                it = Erase<ByInvId>(it);
            } while (it != m_index.get<ByInvId>().end() &&
                     it->m_invid == invid);
            return false;
        }
 
        // Mark the announcement COMPLETED, and select the next best
        // announcement (the first CANDIDATE_READY) if needed.
        ChangeAndReselect(it, State::COMPLETED);
 
        return true;
    }
 
    void SetTimePoint(std::chrono::microseconds now,
                      ClearExpiredFun clearExpired,
                      EmplaceExpiredFun emplaceExpired) {
        clearExpired();
        // Iterate over all CANDIDATE_DELAYED and REQUESTED from old to new, as
        // long as they're in the past, and convert them to CANDIDATE_READY andc
        // COMPLETED respectively.
        while (!m_index.empty()) {
            auto it = m_index.get<ByTime>().begin();
            if (it->GetState() == State::CANDIDATE_DELAYED &&
                it->m_time <= now) {
                PromoteCandidateReady(m_index.project<ByInvId>(it));
            } else if (it->GetState() == State::REQUESTED &&
                       it->m_time <= now) {
                emplaceExpired(it->m_peer, it->m_invid);
                MakeCompleted(m_index.project<ByInvId>(it));
            } else {
                break;
            }
        }
 
        while (!m_index.empty()) {
            // If time went backwards, we may need to demote CANDIDATE_BEST and
            // CANDIDATE_READY announcements back to CANDIDATE_DELAYED. This is
            // an unusual edge case, and unlikely to matter in production.
            // However, it makes it much easier to specify and test
            // InvRequestTracker::Impl's behaviour.
            auto it = std::prev(m_index.get<ByTime>().end());
            if (it->IsSelectable() && it->m_time > now) {
                ChangeAndReselect(m_index.project<ByInvId>(it),
                                  State::CANDIDATE_DELAYED);
            } else {
                break;
            }
        }
    }
 
public:
    explicit InvRequestTrackerImpl(bool deterministic)
        : m_computer(deterministic),
          // Explicitly initialize m_index as we need to pass a reference to
          // m_computer to ByInvIdViewExtractor.
          m_index(boost::make_tuple(
              boost::make_tuple(ByPeerViewExtractor(), std::less<ByPeerView>()),
              boost::make_tuple(ByInvIdViewExtractor(m_computer),
                                std::less<ByInvIdView>()),
              boost::make_tuple(ByTimeViewExtractor(),
                                std::less<ByTimeView>()))) {}
 
    // Disable copying and assigning (a default copy won't work due the stateful
    // ByInvIdViewExtractor).
    InvRequestTrackerImpl(const InvRequestTrackerImpl &) = delete;
    InvRequestTrackerImpl &operator=(const InvRequestTrackerImpl &) = delete;
 
    ~InvRequestTrackerImpl() = default;
 
    void DisconnectedPeer(NodeId peer) {
        auto &index = m_index.get<ByPeer>();
        auto it =
            index.lower_bound(ByPeerView{peer, false, uint256(uint256::ZERO)});
        while (it != index.end() && it->m_peer == peer) {
            // Check what to continue with after this iteration. 'it' will be
            // deleted in what follows, so we need to decide what to continue
            // with afterwards. There are a number of cases to consider:
            // - std::next(it) is end() or belongs to a different peer. In that
            //   case, this is the last iteration of the loop (denote this by
            //   setting it_next to end()).
            // - 'it' is not the only non-COMPLETED announcement for its invid.
            //   This means it will be deleted, but no other Announcement
            //   objects will be modified. Continue with std::next(it) if it
            //   belongs to the same peer, but decide this ahead of time (as
            //   'it' may change position in what follows).
            // - 'it' is the only non-COMPLETED announcement for its invid. This
            //   means it will be deleted along with all other announcements for
            //   the same invid - which may include std::next(it). However,
            //   other than 'it', no announcements for the same peer can be
            //   affected (due to (peer, invid) uniqueness). In other words, the
            //   situation where std::next(it) is deleted can only occur if
            //   std::next(it) belongs to a different peer but the same invid as
            //   'it'. This is covered by the first bulletpoint already, and
            //   we'll have set it_next to end().
            auto it_next =
                (std::next(it) == index.end() || std::next(it)->m_peer != peer)
                    ? index.end()
                    : std::next(it);
            // If the announcement isn't already COMPLETED, first make it
            // COMPLETED (which will mark other CANDIDATEs as CANDIDATE_BEST, or
            // delete all of a invid's announcements if no non-COMPLETED ones
            // are left).
            if (MakeCompleted(m_index.project<ByInvId>(it))) {
                // Then actually delete the announcement (unless it was already
                // deleted by MakeCompleted).
                Erase<ByPeer>(it);
            }
            it = it_next;
        }
    }
 
    void ForgetInvId(const uint256 &invid) {
        auto it = m_index.get<ByInvId>().lower_bound(
            ByInvIdView{invid, State::CANDIDATE_DELAYED, 0});
        while (it != m_index.get<ByInvId>().end() && it->m_invid == invid) {
            it = Erase<ByInvId>(it);
        }
    }
 
    void ReceivedInv(NodeId peer, const uint256 &invid, bool preferred,
                     std::chrono::microseconds reqtime) {
        // Bail out if we already have a CANDIDATE_BEST announcement for this
        // (invid, peer) combination. The case where there is a
        // non-CANDIDATE_BEST announcement already will be caught by the
        // uniqueness property of the ByPeer index when we try to emplace the
        // new object below.
        if (m_index.get<ByPeer>().count(ByPeerView{peer, true, invid})) {
            return;
        }
 
        // Try creating the announcement with CANDIDATE_DELAYED state (which
        // will fail due to the uniqueness of the ByPeer index if a
        // non-CANDIDATE_BEST announcement already exists with the same invid
        // and peer). Bail out in that case.
        auto ret = m_index.get<ByPeer>().emplace(invid, peer, preferred,
                                                 reqtime, m_current_sequence);
        if (!ret.second) {
            return;
        }
 
        // Update accounting metadata.
        ++m_peerinfo[peer].m_total;
        ++m_current_sequence;
    }
 
    std::vector<uint256> GetRequestable(NodeId peer,
                                        std::chrono::microseconds now,
                                        ClearExpiredFun clearExpired,
                                        EmplaceExpiredFun emplaceExpired) {
        // Move time.
        SetTimePoint(now, clearExpired, emplaceExpired);
 
        // Find all CANDIDATE_BEST announcements for this peer.
        std::vector<const Announcement *> selected;
        auto it_peer = m_index.get<ByPeer>().lower_bound(
            ByPeerView{peer, true, uint256(uint256::ZERO)});
        while (it_peer != m_index.get<ByPeer>().end() &&
               it_peer->m_peer == peer &&
               it_peer->GetState() == State::CANDIDATE_BEST) {
            selected.emplace_back(&*it_peer);
            ++it_peer;
        }
 
        // Sort by sequence number.
        std::sort(selected.begin(), selected.end(),
                  [](const Announcement *a, const Announcement *b) {
                      return a->m_sequence < b->m_sequence;
                  });
 
        // Convert to InvId and return.
        std::vector<uint256> ret;
        ret.reserve(selected.size());
        std::transform(selected.begin(), selected.end(),
                       std::back_inserter(ret),
                       [](const Announcement *ann) { return ann->m_invid; });
        return ret;
    }
 
    void RequestedData(NodeId peer, const uint256 &invid,
                       std::chrono::microseconds expiry) {
        auto it = m_index.get<ByPeer>().find(ByPeerView{peer, true, invid});
        if (it == m_index.get<ByPeer>().end()) {
            // There is no CANDIDATE_BEST announcement, look for a _READY or
            // _DELAYED instead. If the caller only ever invokes RequestedData
            // with the values returned by GetRequestable, and no other
            // non-const functions other than ForgetInvId and GetRequestable in
            // between, this branch will never execute (as invids returned by
            // GetRequestable always correspond to CANDIDATE_BEST
            // announcements).
 
            it = m_index.get<ByPeer>().find(ByPeerView{peer, false, invid});
            if (it == m_index.get<ByPeer>().end() ||
                (it->GetState() != State::CANDIDATE_DELAYED &&
                 it->GetState() != State::CANDIDATE_READY)) {
                // There is no CANDIDATE announcement tracked for this peer, so
                // we have nothing to do. Either this invid wasn't tracked at
                // all (and the caller should have called ReceivedInv), or it
                // was already requested and/or completed for other reasons and
                // this is just a superfluous RequestedData call.
                return;
            }
 
            // Look for an existing CANDIDATE_BEST or REQUESTED with the same
            // invid. We only need to do this if the found announcement had a
            // different state than CANDIDATE_BEST. If it did, invariants
            // guarantee that no other CANDIDATE_BEST or REQUESTED can exist.
            auto it_old = m_index.get<ByInvId>().lower_bound(
                ByInvIdView{invid, State::CANDIDATE_BEST, 0});
            if (it_old != m_index.get<ByInvId>().end() &&
                it_old->m_invid == invid) {
                if (it_old->GetState() == State::CANDIDATE_BEST) {
                    // The data structure's invariants require that there can be
                    // at most one CANDIDATE_BEST or one REQUESTED announcement
                    // per invid (but not both simultaneously), so we have to
                    // convert any existing CANDIDATE_BEST to another
                    // CANDIDATE_* when constructing another REQUESTED. It
                    // doesn't matter whether we pick CANDIDATE_READY or
                    // _DELAYED here, as SetTimePoint() will correct it at
                    // GetRequestable() time. If time only goes forward, it will
                    // always be _READY, so pick that to avoid extra work in
                    // SetTimePoint().
                    Modify<ByInvId>(it_old, [](Announcement &ann) {
                        ann.SetState(State::CANDIDATE_READY);
                    });
                } else if (it_old->GetState() == State::REQUESTED) {
                    // As we're no longer waiting for a response to the previous
                    // REQUESTED announcement, convert it to COMPLETED. This
                    // also helps guaranteeing progress.
                    Modify<ByInvId>(it_old, [](Announcement &ann) {
                        ann.SetState(State::COMPLETED);
                    });
                }
            }
        }
 
        Modify<ByPeer>(it, [expiry](Announcement &ann) {
            ann.SetState(State::REQUESTED);
            ann.m_time = expiry;
        });
    }
 
    void ReceivedResponse(NodeId peer, const uint256 &invid) {
        // We need to search the ByPeer index for both (peer, false, invid) and
        // (peer, true, invid).
        auto it = m_index.get<ByPeer>().find(ByPeerView{peer, false, invid});
        if (it == m_index.get<ByPeer>().end()) {
            it = m_index.get<ByPeer>().find(ByPeerView{peer, true, invid});
        }
        if (it != m_index.get<ByPeer>().end()) {
            MakeCompleted(m_index.project<ByInvId>(it));
        }
    }
 
    size_t CountInFlight(NodeId peer) const {
        auto it = m_peerinfo.find(peer);
        if (it != m_peerinfo.end()) {
            return it->second.m_requested;
        }
        return 0;
    }
 
    size_t CountCandidates(NodeId peer) const {
        auto it = m_peerinfo.find(peer);
        if (it != m_peerinfo.end()) {
            return it->second.m_total - it->second.m_requested -
                   it->second.m_completed;
        }
        return 0;
    }
 
    size_t Count(NodeId peer) const {
        auto it = m_peerinfo.find(peer);
        if (it != m_peerinfo.end()) {
            return it->second.m_total;
        }
        return 0;
    }
 
    size_t Size() const { return m_index.size(); }
 
    uint64_t ComputePriority(const uint256 &invid, NodeId peer,
                             bool preferred) const {
        // Return Priority as a uint64_t as Priority is internal.
        return uint64_t{m_computer(invid, peer, preferred)};
    }
};
 
std::unique_ptr<InvRequestTrackerImplInterface>
InvRequestTrackerImplInterface::BuildImpl(bool deterministic) {
    return std::make_unique<InvRequestTrackerImpl>(deterministic);
}